ECE 2524

Introduction to Unix for Engineers

Review of Battleship

Usage

Battleship was quite interesting game. The concept of it was good but instruction wise in the README was not clear. All it explained was to compile and run it, not how the game is played. The game compiled and executed without any issues, but using it took a bit. If entered a random value, not specified in the game, it would loop, and I cannot get out of it, but overall this is a well made game.

Style

The coding seems well organized, where each class had their own job along with their cpp and header files, looking at it worked but I am not sure what a good amount of it do. Some comments may be needed. Also for the github descriptions of the files, it looks quite unprofessional with it being un-capitalized, and it really doesn’t describe the file too much.

Philosophy

They did have many rules of Unix along their project - They did well with modularity, where each functions that are spread out and used throughout, with each function do their job. - Each of the function names were quite clear.

  • The code was simple enough for most C++ users to understand.

  • The game itself was pretty simple as well.

As I see now it follows the design philosophy quite well and runs well.

Improvements?

I mean it was well done, they could add comments into the code to clarify some things, but they should fix it where taking an input that is not a supposed input, it would loop and error. They could also put in instructions or tell the player if he was hit or not. Overall this was quite an experience to play with.