ECE 2524

Introduction to Unix for Engineers

This review is such a DEAL

This game is a Deal!

Usage

Deal or No Deal(https:://github.com/mamapop/dealornodeal) was a super fun game. The README file had all the instructions that were necessary to run the game. There were some warnings when I executed the makefile, but that was no problem since the game ran just fine. The game definitely passed my expectations and it was really fun. I ended up just wanting to know how much money was in my case. Its a real gamble.

I only had to run these commands to get the game started:

$ make
$ ./deal

Style

The code was relatively easy to read. All the functions have easy to understand names that give a good sense of what everything does. A thing that I would maybe change is create more than just one file. I liked that there wasnt a mass of files in your repository, but splitting up one giant file into a few smaller ones might give the program a little more oversight. A header file might be useful to just get an overview of all the functions the program contains.

These are some things I liked about the Style:

- All functions were easy to read and understand
- The main contained case statements that used the input to interact with the functions
- The code follows a simple, yet fundamentally stable design

Philosophy

This program follows the UNIX design philosophy relatively well. There are things implemented such as modularity, silence, simplicity, and clarity, that really make the program easy to understand, and easy to change. A thing to add could be more seperation between the functions and the main as I mentioned above.

Recommendations for Improvement

Overall, I loved the game, its really fun, and has a great visual interface that lets the user know exactly what cases they have left. There are some things I noticed that could be changed which are:

- At one point I had $25,000 and $750,000 left, and I was offered $26,000 by the bank. I recommend you change your banker algorithm a little to accomadate for this.
- A cool option to implement would be the ability to switch cases once there are only 2 left.